Announcement

Collapse
No announcement yet.

Disable Knock control during hard spark cut launch control.

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • Disable Knock control during hard spark cut launch control.

    I was testing the logging ADX and logged during a quick blip of hard spark cut lunch control i noticed the knock control being triggered. Im not sure if anyone else has noticed this yet or if its just my car. i had an idea about adding to the code so that when the RAM variable is pushed for spark cut it also disables knock. i think i figured out how PRJ disabled knock by clearing P4.7 as shown in the code for the hard spark cut RPM limiter and NLS but i may be wrong on that.
    "The really good drivers got the bugs on the side windows." Walter Röhrl

  • #2
    It's already done in the mod.
    If your knock control got triggered it was not during the shift and most likely you actually have knock on onset.
    http://tuner.ee - http://www.facebook.com/tuner.ee

    Comment


    • #3
      i should have asked first if the knock values get filled regardless if knock is enabled or not in data logging. after i thought about it more is it possible for the knock values in logging to display timing retard even though the knock flag is set too disable? i have not ran my car on the no lift shift yet so i have not seen how that part of the knock control disable works in action in a data log. i have the knock off RPM at like 6800RPM so it doesnt interfere with the rest of the lower RPM range where as my launch control RPM is only 5000RPM. so i guess its impossible to clear P4.7 during launch control because my disable RPM is higher than my launch control.

      my idea is when in the launch control part of the patch clearing P4.7 right before the push of the ignition angle value to RAM 53 since you have it setup that LC has its own separate push to RAM 53. i figure pushing right before the push to RAM 53 should be enough to to shut of knock control on boost side before it backfires and tries to trigger a knock event. it could be possible to do this on the NLS and hard spark cut limiter too to get rid of the RPM based code. than patches could be used to turn knock control on/off, like when off the patch would just NOP the clearing of P4.7. you understand the ECU far better than i do and i know you have your reasons for how you format everything so these are Just ideas to make it work more efficiently.
      Last edited by prj; 24 January 2018, 09:39.
      "The really good drivers got the bugs on the side windows." Walter Röhrl

      Comment


      • #4
        You are trying to solve a problem that does not exist, and that was solved long ago.

        There are two separate knock control disables, one for LC, one for hardcut revlimiter.
        They are both used depending on circumstances. Take the bigturbo base file and STUDY how things are done.

        Stop typing unneccessary yadda yadda and start reading code, i've solved all of this years and and the code is in the bin.

        Also, all this ADDAT **** is offtopic, it's got nothing to do with knock control. I already asked you to post to post in appropriate threads about things...
        Cleaned up again.
        http://tuner.ee - http://www.facebook.com/tuner.ee

        Comment

        Working...
        X